From 66e3a8ee3614741d698ec513fcd75ac2e92f4049 Mon Sep 17 00:00:00 2001 From: kolaente Date: Thu, 15 Oct 2026 17:50:01 +0200 Subject: [PATCH] fix: demultiplex docker exec output when saving dumps Non-TTY exec output carries 8-byte frame headers, which were written into dump files and corrupted them. stderr was mixed in as well. --- save.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/save.go b/save.go index 54aaa01..d043e50 100644 --- a/save.go +++ b/save.go @@ -9,6 +9,7 @@ import ( "github.com/docker/docker/api/types/container" "github.com/docker/docker/client" + "github.com/docker/docker/pkg/stdcopy" ) func runAndSaveCommandInContainer(c *client.Client, ctr *container.InspectResponse, command string, args ...string) error { @@ -53,7 +54,8 @@ func runAndSaveCommandInContainer(c *client.Client, ctr *container.InspectRespon target = gw } - _, err = io.Copy(target, resp.Reader) + // Non-TTY exec output is multiplexed with frame headers. + _, err = stdcopy.StdCopy(target, os.Stderr, resp.Reader) if err != nil { return err }